You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/15 06:14:14 UTC

[GitHub] [pulsar] hrsakai opened a new pull request #8065: Change bookkeeper main method class

hrsakai opened a new pull request #8065:
URL: https://github.com/apache/pulsar/pull/8065


   
   ### Motivation
   * `BookieServer::main()` is legacy method.
   https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java#L310-L315
   ```
       /**
        * Legacy Method to run bookie server.
        */
       public static void main(String[] args) {
           Main.main(args);
       }
   
   ```
   
   ### Modifications
   
   * Call `Main::main()` instead of `BookieServer::main()`.
   https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java#L202-L205
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8065: Change bookkeeper main method class

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8065:
URL: https://github.com/apache/pulsar/pull/8065#issuecomment-692516608


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #8065: Change bookkeeper main method class

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #8065:
URL: https://github.com/apache/pulsar/pull/8065


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org