You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "chupaty (via GitHub)" <gi...@apache.org> on 2023/11/12 23:05:09 UTC
[PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
chupaty opened a new pull request, #2583:
URL: https://github.com/apache/avro/pull/2583
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
Demonstrate failing serde serialization and fix for non-trivial union types
## Verifying this change
This change added tests and can be verified as follows:
cargo test
## Documentation
None added. We're a bit short in this area...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2583:
URL: https://github.com/apache/avro/pull/2583#discussion_r1391060320
##########
lang/rust/avro/src/encode.rs:
##########
@@ -242,11 +252,26 @@ pub(crate) fn encode_internal<S: Borrow<Schema>>(
));
}
}
+ } else if let Schema::Union(UnionSchema{ schemas, .. }) = schema {
+ let original_size = buffer.len();
+ for (index,s) in schemas.iter().enumerate() {
+ encode_long(index as i64, buffer);
+ match encode_internal(value, s, names, enclosing_namespace, buffer) {
+ Ok(_) => return Ok(()),
+ Err(_) => {
+ buffer.truncate(original_size); //undo any partial encoding
Review Comment:
Should we exit/break the loop in this case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2583:
URL: https://github.com/apache/avro/pull/2583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2583:
URL: https://github.com/apache/avro/pull/2583#discussion_r1391063952
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
Review Comment:
It would be better to return a `AvroResult<T>` here and replace as many as possible `.unwrap()` calls with `?`
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
+ where T: DeserializeOwned + Serialize {
+ let mut encoded: Vec<u8> = Vec::new();
+ let mut writer = Writer::with_schemata(&schema, schemata.iter().collect(), &mut encoded, Codec::Null);
+ writer.append_ser(input).unwrap();
+ writer.flush().unwrap();
+
+ let mut reader = Reader::with_schemata(schema, schemata.iter().collect(), encoded.as_slice()).unwrap();
+ from_value::<T>(&reader.next().unwrap().unwrap()).unwrap()
+}
+
+
+#[test]
+fn union_schema_round_trip_no_null() {
Review Comment:
```suggestion
fn test_avro3901_union_schema_round_trip_no_null() {
```
##########
lang/rust/avro/src/encode.rs:
##########
@@ -242,11 +252,26 @@ pub(crate) fn encode_internal<S: Borrow<Schema>>(
));
}
}
+ } else if let Schema::Union(UnionSchema{ schemas, .. }) = schema {
+ let original_size = buffer.len();
+ for (index,s) in schemas.iter().enumerate() {
+ encode_long(index as i64, buffer);
+ match encode_internal(value, s, names, enclosing_namespace, buffer) {
+ Ok(_) => return Ok(()),
+ Err(_) => {
+ buffer.truncate(original_size); //undo any partial encoding
Review Comment:
Should we exit/break the loop in this case ?
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
+ where T: DeserializeOwned + Serialize {
+ let mut encoded: Vec<u8> = Vec::new();
+ let mut writer = Writer::with_schemata(&schema, schemata.iter().collect(), &mut encoded, Codec::Null);
+ writer.append_ser(input).unwrap();
+ writer.flush().unwrap();
+
+ let mut reader = Reader::with_schemata(schema, schemata.iter().collect(), encoded.as_slice()).unwrap();
+ from_value::<T>(&reader.next().unwrap().unwrap()).unwrap()
+}
+
+
+#[test]
+fn union_schema_round_trip_no_null() {
+ let schemata: Vec<Schema> = Schema::parse_list(&[SCHEMA_A_STR, SCHEMA_B_STR, SCHEMA_C_STR]).expect("parsing schemata");
+
+ {
+ let input = C { field_union: (UnionAB::A(A { field_a: 45.5 })), field_c: "foo".to_string() };
+ let output = encode_decode(&input,&schemata[2],&schemata);
+ assert_eq!(input,output);
+ }
+ {
+ let input = C { field_union: (UnionAB::B(B { field_b: 73 })), field_c: "bar".to_string() };
+ let output = encode_decode(&input,&schemata[2],&schemata);
+ assert_eq!(input,output);
+ }
+}
+
+static SCHEMA_D_STR: &str = r#"{
+ "name": "D",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["null", "A", "B"]},
+ {"name": "field_d", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionNoneAB {
+ None,
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct D {
+ field_union: UnionNoneAB,
+ field_d: String
+}
+
+#[test]
+fn union_schema_round_trip_null_at_start() {
Review Comment:
```suggestion
fn test_avro3901_union_schema_round_trip_null_at_start() {
```
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
+ where T: DeserializeOwned + Serialize {
+ let mut encoded: Vec<u8> = Vec::new();
+ let mut writer = Writer::with_schemata(&schema, schemata.iter().collect(), &mut encoded, Codec::Null);
+ writer.append_ser(input).unwrap();
+ writer.flush().unwrap();
+
+ let mut reader = Reader::with_schemata(schema, schemata.iter().collect(), encoded.as_slice()).unwrap();
+ from_value::<T>(&reader.next().unwrap().unwrap()).unwrap()
+}
+
+
+#[test]
+fn union_schema_round_trip_no_null() {
+ let schemata: Vec<Schema> = Schema::parse_list(&[SCHEMA_A_STR, SCHEMA_B_STR, SCHEMA_C_STR]).expect("parsing schemata");
+
+ {
Review Comment:
No need of the scoping. Rust is fine with shadowing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
Posted by "chupaty (via GitHub)" <gi...@apache.org>.
chupaty commented on code in PR #2583:
URL: https://github.com/apache/avro/pull/2583#discussion_r1391804675
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
Review Comment:
Done - thanks
##########
lang/rust/avro/tests/union_schema.rs:
##########
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use serde::{Deserialize, Serialize};
+use serde::de::DeserializeOwned;
+use apache_avro::{from_value, Schema, Writer, Reader, Codec};
+
+
+static SCHEMA_A_STR: &str = r#"{
+ "name": "A",
+ "type": "record",
+ "fields": [
+ {"name": "field_a", "type": "float"}
+ ]
+ }"#;
+
+static SCHEMA_B_STR: &str = r#"{
+ "name": "B",
+ "type": "record",
+ "fields": [
+ {"name": "field_b", "type": "long"}
+ ]
+ }"#;
+
+static SCHEMA_C_STR: &str = r#"{
+ "name": "C",
+ "type": "record",
+ "fields": [
+ {"name": "field_union", "type": ["A", "B"]},
+ {"name": "field_c", "type": "string"}
+ ]
+ }"#;
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct A {
+ field_a: f32,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct B {
+ field_b: i64,
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+#[serde(untagged)]
+enum UnionAB {
+ A(A),
+ B(B),
+}
+
+#[derive(Serialize,Deserialize,Clone, PartialEq, Debug)]
+struct C {
+ field_union: UnionAB,
+ field_c: String
+}
+
+fn encode_decode<T> (input: &T,schema: &Schema,schemata: &Vec<Schema>) -> T
+ where T: DeserializeOwned + Serialize {
+ let mut encoded: Vec<u8> = Vec::new();
+ let mut writer = Writer::with_schemata(&schema, schemata.iter().collect(), &mut encoded, Codec::Null);
+ writer.append_ser(input).unwrap();
+ writer.flush().unwrap();
+
+ let mut reader = Reader::with_schemata(schema, schemata.iter().collect(), encoded.as_slice()).unwrap();
+ from_value::<T>(&reader.next().unwrap().unwrap()).unwrap()
+}
+
+
+#[test]
+fn union_schema_round_trip_no_null() {
+ let schemata: Vec<Schema> = Schema::parse_list(&[SCHEMA_A_STR, SCHEMA_B_STR, SCHEMA_C_STR]).expect("parsing schemata");
+
+ {
Review Comment:
Done - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3901: [Rust] Unit tests and impl for better union support [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2583:
URL: https://github.com/apache/avro/pull/2583#issuecomment-1810226106
Thank you, @chupaty !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org