You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mdeshmu (via GitHub)" <gi...@apache.org> on 2023/05/11 16:10:01 UTC
[GitHub] [superset] mdeshmu opened a new pull request, #24021: feat(docker): Build python 3.11 docker image
mdeshmu opened a new pull request, #24021:
URL: https://github.com/apache/superset/pull/24021
### SUMMARY
We want to use Python 3.11 in the docker image to benefit from its performance improvements.
### TESTING INSTRUCTIONS
Run the docker build and see if it works with Python 3.11
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backward-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #24021: feat(docker): Build python 3.11 docker image
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #24021:
URL: https://github.com/apache/superset/pull/24021#discussion_r1191468591
##########
.github/workflows/docker_build_push.sh:
##########
@@ -70,6 +70,20 @@ docker build --target lean \
--label "build_actor=${GITHUB_ACTOR}" \
.
+#
+# Build the "lean311" image
+#
+docker build --target lean \
Review Comment:
Does `3.11` work yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu closed pull request #24021: feat(docker): Build python 3.11 docker image
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu closed pull request #24021: feat(docker): Build python 3.11 docker image
URL: https://github.com/apache/superset/pull/24021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #24021: feat(docker): Build python 3.11 docker image
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #24021:
URL: https://github.com/apache/superset/pull/24021#issuecomment-1545276711
Closing in favor of upcoming PR as per [this comment](https://github.com/apache/superset/pull/23804#issuecomment-1545250796).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #24021: feat(docker): Build python 3.11 docker image
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #24021:
URL: https://github.com/apache/superset/pull/24021#discussion_r1191907137
##########
.github/workflows/docker_build_push.sh:
##########
@@ -70,6 +70,20 @@ docker build --target lean \
--label "build_actor=${GITHUB_ACTOR}" \
.
+#
+# Build the "lean311" image
+#
+docker build --target lean \
Review Comment:
@craig-rueda Yes, look at #22217 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org