You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Thomas Diesler (JIRA)" <ji...@apache.org> on 2009/04/01 09:11:12 UTC
[jira] Created: (FELIX-1020) Footer redered before content in
bundle plugin
Footer redered before content in bundle plugin
----------------------------------------------
Key: FELIX-1020
URL: https://issues.apache.org/jira/browse/FELIX-1020
Project: Felix
Issue Type: Bug
Components: Web Console
Affects Versions: webconsole-1.2.8
Reporter: Thomas Diesler
The BundlesServlet incorrectly renders the content like this
pw.println( "<div id='plugin_content'/>");
Util.startScript( pw );
pw.print( "renderBundles(");
writeJSON(pw, reqInfo.bundle);
pw.println(");" );
Util.endScript( pw );
It should however be
pw.println( "<div id='plugin_content'>");
Util.startScript( pw );
pw.print( "renderBundles(");
writeJSON(pw, reqInfo.bundle);
pw.println(");" );
Util.endScript( pw );
pw.println( "</div");
The <script> tag should be enclosed in the <div>
The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1020) Footer redered before content in bundle
plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FELIX-1020.
-----------------------------------
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-2.0.0
>
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Thomas Diesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727435#action_12727435 ]
Thomas Diesler commented on FELIX-1020:
---------------------------------------
Please also note, that I had to modify endResponse(PrintWriter) to take the additional req parameter for attr access
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-1020) Footer redered before
content in bundle plugin
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753489#action_12753489 ]
Felix Meschberger edited comment on FELIX-1020 at 9/10/09 1:03 AM:
-------------------------------------------------------------------
Thomas, can you please check with the latest SNAPSHOT whether this issue still exists ?
You may use top-of-trunk or grab SNAPSHOT version 1.2.11-20090910.080257-2.
Thanks.
was (Author: fmeschbe):
Thomas, can you please check with the latest SNAPSHOT whether this issue still exists ?
Thanks.
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Thomas Diesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694412#action_12694412 ]
Thomas Diesler commented on FELIX-1020:
---------------------------------------
Same is true for EventAdmin
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned FELIX-1020:
---------------------------------------
Assignee: Carsten Ziegeler
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703360#action_12703360 ]
Carsten Ziegeler commented on FELIX-1020:
-----------------------------------------
Hi Thomas,
I can't reproduce this problem. Can you give more information? Otherwise I'll close the bug.
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694453#action_12694453 ]
Carsten Ziegeler commented on FELIX-1020:
-----------------------------------------
The div is used later on for the dynamic content. That's why the script is actually outside of the div. Can you attach a screen shot which shows the problems?
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Thomas Diesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Diesler updated FELIX-1020:
----------------------------------
Attachment: Screenshot-LogService.png
I attached a screen shot that shows that shows how the footer is rendered at the top of the page instead of the bottom
public class LogServicePlugin extends LogServlet
{
private static final long serialVersionUID = 1L;
@Override
protected String getHeader()
{
return PluginHelper.getHeader();
}
@Override
protected void endResponse(HttpServletRequest request, PrintWriter pw)
{
String appRoot = (String)request.getAttribute(OsgiManager.ATTR_APP_ROOT);
String footer = MessageFormat.format(PluginHelper.getFooter(), new Object[]{ appRoot });
pw.println(footer);
}
}
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved FELIX-1020.
-------------------------------------
Resolution: Fixed
Fix Version/s: webconsole-2.0.0
The fix has been released with the web console 2.0.0 - therefore I'm now closing this bug.
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-2.0.0
>
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753489#action_12753489 ]
Felix Meschberger commented on FELIX-1020:
------------------------------------------
Thomas, can you please check with the latest SNAPSHOT whether this issue still exists ?
Thanks.
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1020) Footer redered before content in
bundle plugin
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733334#action_12733334 ]
Carsten Ziegeler commented on FELIX-1020:
-----------------------------------------
I just fixed one potential problem, the main div has never been closed.
But I'm not sure that this is your problem. I'm wondering what the PluginHelper class which you're refering to in your example is doing? Where does it come from?
> Footer redered before content in bundle plugin
> ----------------------------------------------
>
> Key: FELIX-1020
> URL: https://issues.apache.org/jira/browse/FELIX-1020
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-1.2.8
> Reporter: Thomas Diesler
> Assignee: Carsten Ziegeler
> Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
> pw.println( "<div id='plugin_content'/>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> It should however be
> pw.println( "<div id='plugin_content'>");
> Util.startScript( pw );
> pw.print( "renderBundles(");
> writeJSON(pw, reqInfo.bundle);
> pw.println(");" );
> Util.endScript( pw );
> pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.