You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 00:14:56 UTC
[GitHub] [airflow] turbaszek opened a new pull request #13146: Use generic information in UpdateMask component
turbaszek opened a new pull request #13146:
URL: https://github.com/apache/airflow/pull/13146
The UpdateMask is used in connection, pools, variables and dag. So the docs should be more generic. Currently the connection reference in DAG patch is little strange:
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html?#operation/patch_dag
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13146: Use generic information in UpdateMask component
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13146:
URL: https://github.com/apache/airflow/pull/13146#discussion_r545528436
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -2784,8 +2784,8 @@ components:
items:
type: string
description: |
- The fields to update on the connection (connection, pool etc). If absent or empty, all
- modifiable fields are updated. A comma-separated list of fully qualified names of fields.
+ The fields to update on the object. If absent or empty, all modifiable fields are updated.
Review comment:
Object=>resource. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13146: Use generic information in UpdateMask component
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13146:
URL: https://github.com/apache/airflow/pull/13146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13146: Use generic information in UpdateMask component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13146:
URL: https://github.com/apache/airflow/pull/13146#issuecomment-748019978
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org