You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/13 22:06:34 UTC

[GitHub] fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

fhueske commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/6666#discussion_r217547642
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableSourceITCase.scala
 ##########
 @@ -742,6 +742,42 @@ class TableSourceITCase(
     TestBaseUtils.compareResultAsText(results.asJava, expected)
   }
 
+  @Test
+  def testTableSourceScanWithConversion(): Unit = {
 
 Review comment:
   Rename to `testTableSourceScanWithPermutedFields`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services