[jira] [Commented] (SCOUT-106) why do you have defaults for queryManagerURL and other but require them being set via properties when creating a connection?

["Kurt T Stam (JIRA)" <sc...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/SCOUT-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057606#comment-13057606 ] 

Kurt T Stam commented on SCOUT-106:
-----------------------------------

Hi subes,

The idea is that you can override the setting of for example the javax.xml.registry.queryManagerURL property by setting the scout.proxy.inquiryURL property. 
That said, this stuff was implemented before I joined the project and I can't really think of a reason why this would come in handy. It sure seems to make
things hard to understand. If there is no one who objects I may just decide to rip this override mechanism out. 

--Kurt

> why do you have defaults for queryManagerURL and other but require them being set via properties when creating a connection?
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SCOUT-106
>                 URL: https://issues.apache.org/jira/browse/SCOUT-106
>             Project: Scout
>          Issue Type: Improvement
>            Reporter: subes
>            Assignee: Kurt T Stam
>             Fix For: 1.2.4
>
>
> When queryManager is not set, the exception is helpful:
> Caused by: javax.xml.registry.InvalidRequestException: queryManager is not set
> 	at org.apache.ws.scout.registry.ConnectionFactoryImpl.createConnection(ConnectionFactoryImpl.java:75) ~[scout-1.2.1.jar:na]
> 	at de.invesdwin.gemeinsam.integration.ws.internal.jaxr.JaxrClient.open(JaxrClient.java:127) ~[bin/:na]
> 	at de.invesdwin.gemeinsam.integration.ws.internal.jaxr.JaxrClient.registerService(JaxrClient.java:45) ~[bin/:na]
> 	... 67 common frames omitted
> but i wonder why you have default constants in org.apache.ws.scout.registr.RegistryImpl for those which get set on the init method if the properties are not provided by client code?
> Properties prop = new Properties();
> prop.setProperty("javax.xml.registry.queryManagerURL", UDDIInquiryService.class.getName() + "#inquire"); <-
> prop.setProperty("javax.xml.registry.lifeCycleManagerURL", UDDIPublicationService.class.getName() + "#publish"); <-
> prop.setProperty("javax.xml.registry.securityManagerURL", UDDISecurityService.class.getName() + "#secure"); <-
> prop.setProperty(RegistryImpl.TRANSPORT_CLASS_PROPERTY_NAME, LocalTransport.class.getName());
>         prop.setProperty(RegistryV3Impl.UDDI_VERSION_PROPERTY_NAME, "3.0");
>         prop.setProperty(RegistryV3Impl.UDDI_NAMESPACE_PROPERTY_NAME, "urn:uddi-org:api_v3");
> ConnectionFactory factory = ConnectionFactory.newInstance();
> factory.setProperties(prop);
> org.apache.ws.scout.registry.RegistryV3Impl has the same kind of pointless behaviour.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira