You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2015/10/03 00:59:26 UTC
[jira] [Commented] (HBASE-14499) Master coprocessors shutdown will
not happen on master abort
[ https://issues.apache.org/jira/browse/HBASE-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941925#comment-14941925 ]
Ted Yu commented on HBASE-14499:
--------------------------------
Ran the failed tests locally with patch which passed.
> Master coprocessors shutdown will not happen on master abort
> ------------------------------------------------------------
>
> Key: HBASE-14499
> URL: https://issues.apache.org/jira/browse/HBASE-14499
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Pankaj Kumar
> Assignee: Pankaj Kumar
> Attachments: HBASE-14499.patch, HBASE-14499.patch
>
>
> In HMaster,
> {code}
> @Override
> public void abort(final String msg, final Throwable t) {
> if (isAborted() || isStopped()) {
> return;
> }
> if (cpHost != null) {
> // HBASE-4014: dump a list of loaded coprocessors.
> LOG.fatal("Master server abort: loaded coprocessors are: " +
> getLoadedCoprocessors());
> }
> if (t != null) LOG.fatal(msg, t);
> stop(msg);
> }
> {code}
> Here we are invoking stop(...) of HRegionServer, which will try to stop RS coprocessors if rsHost is not NULL.
> So Master coprocessors will not be stopped. We should invoke stopMaster() instead of stop(...).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)