You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2015/07/13 05:43:35 UTC
cordova-browser git commit: CB-9350 'cordova run browser' throws an
exception.
Repository: cordova-browser
Updated Branches:
refs/heads/master 0044fe33c -> ce09dff44
CB-9350 'cordova run browser' throws an exception.
cordova-browser's 'run' command was using an old (never released) API for cordova-serve (I clearly checked in the wrong code when adding cordova-serve support to cordova-browser).
Project: http://git-wip-us.apache.org/repos/asf/cordova-browser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-browser/commit/ce09dff4
Tree: http://git-wip-us.apache.org/repos/asf/cordova-browser/tree/ce09dff4
Diff: http://git-wip-us.apache.org/repos/asf/cordova-browser/diff/ce09dff4
Branch: refs/heads/master
Commit: ce09dff44d625d92f8b82813c71551cdd77b038d
Parents: 0044fe3
Author: Tim Barham <ti...@microsoft.com>
Authored: Mon Jul 13 11:38:07 2015 +1000
Committer: Tim Barham <ti...@microsoft.com>
Committed: Mon Jul 13 11:38:07 2015 +1000
----------------------------------------------------------------------
bin/templates/project/cordova/run | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-browser/blob/ce09dff4/bin/templates/project/cordova/run
----------------------------------------------------------------------
diff --git a/bin/templates/project/cordova/run b/bin/templates/project/cordova/run
index 4ca30a6..a211ab4 100755
--- a/bin/templates/project/cordova/run
+++ b/bin/templates/project/cordova/run
@@ -44,10 +44,10 @@ function start(argv) {
configXML = fs.readFileSync(configFile, 'utf8'),
sourceFile = /<content[\s]+?src\s*=\s*"(.*?)"/i.exec(configXML);
- serve.servePlatform({platform:'browser', port:args.port}).then(function (serverInfo) {
+ serve.servePlatform('browser', {port: args.port}).then(function (serverInfo) {
var projectUrl = url.resolve('http://localhost:' + serverInfo.port + '/', sourceFile ? sourceFile[1] : 'index.html');
console.log('Static file server running @ ' + projectUrl + '\nCTRL + C to shut down');
- return serve.launchBrowser(args.target, projectUrl);
+ return serve.launchBrowser({target: args.target, url: projectUrl});
}).done();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org