You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/13 17:13:11 UTC

[GitHub] [incubator-shenyu] moremind opened a new pull request, #3551: [type:fixbug] fix-issue-3512

moremind opened a new pull request, #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551

   <!-- Describe your PR here; eg. Fixes #3512-->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 commented on a diff in pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551#discussion_r896425877


##########
shenyu-bootstrap/pom.xml:
##########
@@ -437,6 +437,13 @@
                 </exclusion>
             </exclusions>
         </dependency>
+
+        <!-- apache shenyu data sync start use nacos-->
+        <dependency>
+            <groupId>org.apache.shenyu</groupId>
+            <artifactId>shenyu-spring-boot-starter-sync-data-nacos</artifactId>
+            <version>${project.version}</version>

Review Comment:
   why add this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] moremind commented on a diff in pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
moremind commented on code in PR #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551#discussion_r896479315


##########
shenyu-bootstrap/pom.xml:
##########
@@ -437,6 +437,13 @@
                 </exclusion>
             </exclusions>
         </dependency>
+
+        <!-- apache shenyu data sync start use nacos-->
+        <dependency>
+            <groupId>org.apache.shenyu</groupId>
+            <artifactId>shenyu-spring-boot-starter-sync-data-nacos</artifactId>
+            <version>${project.version}</version>

Review Comment:
   because use nacos sync data，please see #3512



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551#issuecomment-1154200991

   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3551](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (307ebea) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/ad84b5416849663fb20c8a2b28de5b3c5036335d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad84b54) will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3551      +/-   ##
   ============================================
   - Coverage     62.83%   62.78%   -0.05%     
   + Complexity     5574     5566       -8     
   ============================================
     Files           842      842              
     Lines         23351    23351              
     Branches       2118     2118              
   ============================================
   - Hits          14672    14661      -11     
   - Misses         7331     7341      +10     
   - Partials       1348     1349       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `59.57% <0.00%> (-4.26%)` | :arrow_down: |
   | [...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jbGllbnQvU2hlbnl1R3JwY0NsaWVudC5qYXZh) | `8.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `65.27% <0.00%> (-1.39%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ad84b54...307ebea](https://codecov.io/gh/apache/incubator-shenyu/pull/3551?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 closed pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
yu199195 closed pull request #3551: [type:fixbug] fix-issue-3512
URL: https://github.com/apache/incubator-shenyu/pull/3551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] moremind commented on a diff in pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
moremind commented on code in PR #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551#discussion_r897438632


##########
shenyu-bootstrap/pom.xml:
##########
@@ -437,6 +437,13 @@
                 </exclusion>
             </exclusions>
         </dependency>
+
+        <!-- apache shenyu data sync start use nacos-->
+        <dependency>
+            <groupId>org.apache.shenyu</groupId>
+            <artifactId>shenyu-spring-boot-starter-sync-data-nacos</artifactId>
+            <version>${project.version}</version>

Review Comment:
   I will close this pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 commented on a diff in pull request #3551: [type:fixbug] fix-issue-3512

Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #3551:
URL: https://github.com/apache/incubator-shenyu/pull/3551#discussion_r896492881


##########
shenyu-bootstrap/pom.xml:
##########
@@ -437,6 +437,13 @@
                 </exclusion>
             </exclusions>
         </dependency>
+
+        <!-- apache shenyu data sync start use nacos-->
+        <dependency>
+            <groupId>org.apache.shenyu</groupId>
+            <artifactId>shenyu-spring-boot-starter-sync-data-nacos</artifactId>
+            <version>${project.version}</version>

Review Comment:
   we also defualt support websocket，not add this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org