You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/30 21:43:40 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #7624: [SQL Lab] Prevent failed query error from disappearing

etr2460 opened a new pull request #7624: [SQL Lab] Prevent failed query error from disappearing
URL: https://github.com/apache/incubator-superset/pull/7624
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   For some failed queries, the error message would briefly flash for the user, then transition back into the running state. Just as we don't refresh stopped queries, we should also not refresh failed queries. This PR makes that change.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   ![May-30-2019 14-16-13](https://user-images.githubusercontent.com/7409244/58666468-384b6700-82e8-11e9-8510-40af3c4f29b6.gif)
   
   After:
   ![May-30-2019 14-18-21](https://user-images.githubusercontent.com/7409244/58666473-3c778480-82e8-11e9-9eb0-0c154cc3cc4e.gif)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Test a failing query with the change and see the error message displayed. Ensure previously functional queries still work.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @graceguo-supercat, @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org