[GitHub] [hudi] vinothchandar commented on a change in pull request #3778: [HUDI-2502] Refactor index in hudi-client module

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #3778:
URL: https://github.com/apache/hudi/pull/3778#discussion_r732329692



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
##########
@@ -53,17 +53,19 @@ protected HoodieIndex(HoodieWriteConfig config) {
    * present).
    */
   @PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
-  public abstract I tagLocation(I records, HoodieEngineContext context,
-                                HoodieTable<T, I, K, O> hoodieTable) throws HoodieIndexException;
+  public abstract HoodieData<HoodieRecord<T>> tagLocation(

Review comment:
       this is a public API change? I think people typically extend the Spark and Flink subclasses. Something to check. 

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/HoodieWriteMetadata.java
##########
@@ -46,6 +46,36 @@
   public HoodieWriteMetadata() {
   }
 
+  /**
+   * Clones the write metadata with transformed write statuses.
+   *
+   * @param transformedWriteStatuses transformed write statuses
+   * @param <T>                      type of transformed write statuses
+   * @return Cloned {@link HoodieWriteMetadata<T>} instance
+   */
+  public <T> HoodieWriteMetadata<T> clone(T transformedWriteStatuses) {

Review comment:
       this may be changes from the other PR - that introduces `HoodieData`?

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -101,7 +101,7 @@
   private static final Logger LOG = LogManager.getLogger(AbstractHoodieWriteClient.class);
 
   protected final transient HoodieMetrics metrics;
-  private final transient HoodieIndex<T, I, K, O> index;
+  private final transient HoodieIndex index;

Review comment:
       do we need a. `HoodieIndex<?>` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org