You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2015/09/09 03:03:31 UTC
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/335
Multiple updates to cordova plugin search
* Faster gulp live reload workflow for plugin search work
* Add sortBy URL parameter on sorting
* Tweak title and description meta tags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs pluginChanges
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #335
----
commit 8769bc3074eb942621df5742ad30e265689293a0
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2015-09-09T00:55:04Z
Improve live reload workflow when working on plugin changes.
commit 663125f3e89bee260b773abc1a5c9f9d5f9e2380
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2015-09-09T00:56:31Z
Tweak title and description meta tags
commit 1b2519bca23530f5e95ba5247b5a298647ed6aa1
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2015-09-09T00:58:37Z
Add sortBy parameter to the plugin search URL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139000724
The issue is that `{{ site.baseurl }}` strings need to be processed by Jekyll and the updated gulpfile bypasses that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139064740
Merged. Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071423
--- Diff: gulpfile.js ---
@@ -224,7 +223,8 @@ gulp.task("plugins", function() {
}
return stream
-
+ .pipe(browsersync.reload({stream: true}))
+ .pipe(gulp.dest(JS_DIR.replace(SOURCE_DIR, out_dir)))
--- End diff --
I think these should be in the reverse order: first replacing the file and then reloading the browser.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071336
--- Diff: gulpfile.js ---
@@ -234,8 +234,7 @@ gulp.task("plugins", function() {
// minified JS has some things that look like
// Liquid tags, so we replace them manually
.pipe(replace("){{", "){ {"))
-
- .pipe(gulp.dest(JS_DIR));
+ .pipe(gulp.dest(JS_DIR))
--- End diff --
Consistency nit pick: missing semicolon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139040510
Also, it might be useful to switch to a proper URI builder for constructing URIs now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139078394
Thanks Richard for making the fixes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139041694
And yes, we should switch to a URI builder at some point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-138973904
Checking multiple platform filters results in an improperly encoded URL. I have a fix, do you want me to push it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139040608
@dblotsky I addressed your concerns with Gulpfile. Gulp will now reload the browser twice on plugins changes. The first will update the code and the second will be a full push that includes updated `{{ site.baseurl }}` links.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-138743390
@riknoll Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-138993518
Updating a file in the plugins folder causes all image links in the plugins page to be broken once the page refreshes (and on all subsequent refreshes)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071280
--- Diff: gulpfile.js ---
@@ -121,7 +121,7 @@ gulp.task("watch", ["serve"], function () {
path.join(ROOT_DIR, "**", "*.yml"),
path.join(SOURCE_DIR, "**", "*.html"),
path.join(SOURCE_DIR, "**", "*.md"),
- path.join(JS_DIR, "**", "*.js"),
+ path.join(JS_DIR, "**", "*.js" + "!" + PLUGINS_FILE_NAME),
--- End diff --
What's the motivation behind excluding this file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-docs/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org