[GitHub] [hbase] mokai87 commented on a change in pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

[GitBox <gi...@apache.org>]

mokai87 commented on a change in pull request #2219:
URL: https://github.com/apache/hbase/pull/2219#discussion_r470926641



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -199,6 +199,10 @@ public void close() {
     if (!closed.compareAndSet(false, true)) {
       return;
     }
+    LOG.info("Connection has been closed by {}.", Thread.currentThread().getName());

Review comment:
       It is helpful to identify who closed the connection improperly in  production env. 
   Level debug is inconvenient since we have to re-run the user application to reproduce it. Meanwhile, it should not be called frequently.
   Maybe I did not get your concern.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org