[GitHub] [hbase] saintstack commented on a change in pull request #1912: HBASE-24574 Procedure V2 - Distributed WAL Splitting => LOGGING

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1912:
URL: https://github.com/apache/hbase/pull/1912#discussion_r441769423



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALProcedure.java
##########
@@ -192,6 +189,21 @@ protected void afterReplay(MasterProcedureEnv env){
     if(worker != null){
       env.getMasterServices().getSplitWALManager().addUsedSplitWALWorker(worker);
     }
+  }
+
+  @Override protected void toStringClassDetails(StringBuilder builder) {
+    builder.append(getProcName());
+    if (this.worker != null) {
+      builder.append(", splitWorker=");
+      builder.append(this.worker);
+    }
+    if (this.retryCounter != null) {
+      builder.append(", retry=");
+      builder.append(this.retryCounter);
+    }
+  }
 
+  @Override public String getProcName() {
+    return getClass().getSimpleName() + " " + WAL.stripWALsDirPrefix(getWAL());

Review comment:
       You idea is better. Let me do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org