[GitHub] [activemq-artemis] Maverick19841972 commented on pull request #4387: Artemis 4187

["Maverick19841972 (via GitHub)" <gi...@apache.org>]

Maverick19841972 commented on PR #4387:
URL: https://github.com/apache/activemq-artemis/pull/4387#issuecomment-1455113939

   The logDebug method confirms to the already present logging construct in the SizeAwareMetrics-class. e.g. in de addSize-method which uses the logger.isDebugEnable-method: 
   
         if (delta == 0) {
            if (logger.isDebugEnabled()) {
               logger.debug("SizeAwareMetric ignored with size 0", new Exception("trace"));
            }
            return sizeUpdater.get(this);
         }
   
   It is a separate method because op the DRY-principle and the supplier is there to "lazy init" the string for performance reasons.
   
   But I'm more than happy to boyscout out the entire logging contruct ??
   
   Futhermore, I will squash and have a look at the commit-message(s).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org