You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/04/24 02:35:27 UTC
Review Request 20640: Fix createJob to accept non-cron jobs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349
Repository: aurora
Description
-------
Fix createJob to accept non-cron jobs.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 09b7fbd5832991226bc5a012a0a1f5249ac825e6
Diff: https://reviews.apache.org/r/20640/diff/
Testing
-------
./gradlew build
Awaiting e2e run.
Thanks,
Kevin Sweeney
Re: Review Request 20640: Fix createJob to accept non-cron jobs.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/#review41253
-----------------------------------------------------------
-1 no unit test coverage
- Bill Farner
On April 24, 2014, 1:10 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20640/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 1:10 a.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Bugs: AURORA-349
> https://issues.apache.org/jira/browse/AURORA-349
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix createJob to accept non-cron jobs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 09b7fbd5832991226bc5a012a0a1f5249ac825e6
>
> Diff: https://reviews.apache.org/r/20640/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> e2e test is not quite fixed but the part that caused this error is
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 20640: Fix createJob to accept non-cron jobs.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/#review42338
-----------------------------------------------------------
status?
- Brian Wickman
On April 24, 2014, 1:10 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20640/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 1:10 a.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Bugs: AURORA-349
> https://issues.apache.org/jira/browse/AURORA-349
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix createJob to accept non-cron jobs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 09b7fbd5832991226bc5a012a0a1f5249ac825e6
>
> Diff: https://reviews.apache.org/r/20640/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> e2e test is not quite fixed but the part that caused this error is
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 20640: Fix createJob to accept non-cron jobs.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
-----------------------------------------------------------
(Updated April 23, 2014, 6:10 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349
Repository: aurora
Description
-------
Fix createJob to accept non-cron jobs.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 09b7fbd5832991226bc5a012a0a1f5249ac825e6
Diff: https://reviews.apache.org/r/20640/diff/
Testing (updated)
-------
./gradlew build
e2e test is not quite fixed but the part that caused this error is
Thanks,
Kevin Sweeney
Re: Review Request 20640: Fix createJob to accept non-cron jobs.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
-----------------------------------------------------------
(Updated April 23, 2014, 6:06 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349
Repository: aurora
Description
-------
Fix createJob to accept non-cron jobs.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 09b7fbd5832991226bc5a012a0a1f5249ac825e6
Diff: https://reviews.apache.org/r/20640/diff/
Testing (updated)
-------
./gradlew build
Awaiting e2e test
Thanks,
Kevin Sweeney