You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "kali834x (via GitHub)" <gi...@apache.org> on 2026/06/08 17:56:52 UTC
[PR] Fix resource leak in ZipSecureFile constructors and correct path logging in ZipPackage [poi]
kali834x opened a new pull request, #1123:
URL: https://github.com/apache/poi/pull/1123
This PR fixes two issues in the `poi-ooxml` module:
1. Prevents a file descriptor leak in `ZipSecureFile` when `validateEntryNames()` fails during construction by ensuring the opened ZIP file is properly closed on initialization failure.
2. Corrects the warning log in `ZipPackage.closeImpl()` to report the actual temporary file path instead of the target document path when temporary file deletion fails.
Verification
* Added a regression test covering invalid ZIP archives with duplicate entry names and verifying proper resource cleanup.
* All unit tests pass successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Fix resource leak in ZipSecureFile constructors and correct path logging in ZipPackage [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1123:
URL: https://github.com/apache/poi/pull/1123#issuecomment-4652273387
lgtm - thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Fix resource leak in ZipSecureFile constructors and correct path logging in ZipPackage [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1123:
URL: https://github.com/apache/poi/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org