You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2012/04/17 00:46:20 UTC
[jira] [Commented] (ZOOKEEPER-1371) Remove dependency on log4j in
the source code.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255144#comment-13255144 ]
Hadoop QA commented on ZOOKEEPER-1371:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522869/ZOOKEEPER-1371.patch
against trunk revision 1326029.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 15 javac compiler warnings (more than the trunk's current 5 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1034//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1034//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1034//console
This message is automatically generated.
> Remove dependency on log4j in the source code.
> ----------------------------------------------
>
> Key: ZOOKEEPER-1371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3
> Reporter: Mahadev konar
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1371.patch
>
>
> ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We should remove the dependency on log4j so that we can make logging pluggable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira