You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/17 17:37:09 UTC
[GitHub] [hbase] jojochuang opened a new pull request #1179: HBASE-23861.
Reconcile Hadoop version.
jojochuang opened a new pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179
Let it run through the precommit and see if it breaks anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on a change in pull request #1179:
HBASE-23861. Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#discussion_r381506466
##########
File path: hbase-server/pom.xml
##########
@@ -723,9 +723,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-distcp</artifactId>
- <!--This dependency is not in top-level pom so needs
- version specified-->
Review comment:
Hi Nick, not sure i get that. Both hadoop-distcp and hadoop-hdfs-client versions are specified in the hadoop-2 and hadoop-3 profiles in the root pom file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on a change in pull request #1179:
HBASE-23861. Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#discussion_r384179860
##########
File path: hbase-server/pom.xml
##########
@@ -723,9 +723,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-distcp</artifactId>
- <!--This dependency is not in top-level pom so needs
- version specified-->
Review comment:
Ah. good catch. Updated the PR to add this. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-587943008
Looks great to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-589805344
I think the patch doesn't require additional change to support hadoop-2 profile...
mvn clean install -Dhadoop-two.version=2.10.1-SNAPSHOT
mvn -X test -Dtest=TestHelloHBase -Dhadoop-two.version=2.10.1-SNAPSHOT
I see that it uses hadoop-*-2.10-1-SNAPSHOT jars in runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-594790512
Should this change go into lower branches? And what branches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1179:
HBASE-23861. Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#discussion_r381501758
##########
File path: hbase-server/pom.xml
##########
@@ -723,9 +723,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-distcp</artifactId>
- <!--This dependency is not in top-level pom so needs
- version specified-->
Review comment:
Oh, one more thing. Please apply these same changes (picking up the dependency version from the parent pom) to the Hadoop2 profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1179: HBASE-23861.
Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-587935028
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 49s | master passed |
| +1 :green_heart: | compile | 3m 21s | master passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 30s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 31s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 29s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 152m 13s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 1s | The patch does not generate ASF License warnings. |
| | | 215m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1179 |
| Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 90ec5b7ba16a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1179/out/precommit/personality/provided.sh |
| git revision | master / c4fb1cd234 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/2/testReport/ |
| Max. process+thread count | 7255 (vs. ulimit of 10000) |
| modules | C: hbase-server . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-587649367
I reran the qabot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1179: HBASE-23861.
Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-591206638
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 48s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 49s | master passed |
| +1 :green_heart: | compile | 3m 20s | master passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 30s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 35s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 42s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 147m 4s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 213m 3s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1179 |
| Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux a121848a666d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1179/out/precommit/personality/provided.sh |
| git revision | master / 9f223c2236 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/3/testReport/ |
| Max. process+thread count | 7493 (vs. ulimit of 10000) |
| modules | C: hbase-server . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1179:
HBASE-23861. Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#discussion_r384168804
##########
File path: hbase-server/pom.xml
##########
@@ -723,9 +723,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-distcp</artifactId>
- <!--This dependency is not in top-level pom so needs
- version specified-->
Review comment:
Looking at the `hadoop-2.0` profile in `hbase-server/pom.xml`, I see there's a version specified there for the `hadoop-distcp` dependency. You can apply the same change to this profile that you did to the `hadoop-3.0` profile, so that it will resolve the version from the parent pom's profile instead of the hard-coded version.
https://github.com/ndimiduk/hbase/blob/00fc46756abb99de6f833997499505f89c9752e8/hbase-server/pom.xml#L612-L618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-594654432
Thanks for the reviews, Nick and Sean!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-587174353
Test failure doesn't look related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1179: HBASE-23861.
Reconcile Hadoop version.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-587152642
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 54s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 28s | master passed |
| +1 :green_heart: | compile | 4m 16s | master passed |
| +1 :green_heart: | shadedjars | 6m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 43s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 18s | the patch passed |
| +1 :green_heart: | compile | 4m 6s | the patch passed |
| +1 :green_heart: | javac | 4m 6s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 36s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 31s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 115m 1s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 9s | The patch does not generate ASF License warnings. |
| | | 187m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1179 |
| Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 7d3596172417 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1179/out/precommit/personality/provided.sh |
| git revision | master / e11dbf36a5 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/1/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/1/testReport/ |
| Max. process+thread count | 6562 (vs. ulimit of 10000) |
| modules | C: hbase-server . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1179/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1179: HBASE-23861. Reconcile
Hadoop version.
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#issuecomment-595297930
> Should this change go into lower branches? And what branches?
Yes, I think so. Start with `branch-2` -- please make a PR vs `branch-2` that is a cherry-pick of this commit from master.
It probably also applies to `branch-2.2` and `branch-2.1`, but I don't know if @Apache9 and @infraio want such a patch on their respective release lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services