[jira] [Commented] (DRILL-5855) Provide a useful error message when the SystemOptionManager is queried for a non-existent option

["Paul Rogers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195561#comment-16195561 ] 

Paul Rogers commented on DRILL-5855:
------------------------------------

Already fixed in DRILL-5832. With that change, the option manager throws a user exception for a missing option declaration, a missing default value or (using the new methods), a request to return the option as the wrong type. The wording is neutral to alert us developers when we goof; but also to provide a message that is OK for users if we really goof and let the error slip through into the final code.

> Provide a useful error message when the SystemOptionManager is queried for a non-existent option
> ------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5855
>                 URL: https://issues.apache.org/jira/browse/DRILL-5855
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Minor
>
> Currently when the SystemOptionManager is queried for an unregistered option. It throws a null pointer exception. I should probably throw and IllegalArgumentException with an informative message like "There is no OptionDefinition for <option name>. Either you misspelled the option name or you need to add an OptionDefinition for this option to the code base." 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)