[GitHub] [incubator-superset] ktmud commented on issue #10730: Enable sort on multiple columns when interacting with the table viz

[GitBox <gi...@apache.org>]

ktmud commented on issue #10730:
URL: https://github.com/apache/incubator-superset/issues/10730#issuecomment-708961115


   Be careful with rewriting things from ground up. The table chart might be more complex than you think. Current table chart was overhauled only a couple of months ago. It took me about 3 weeks to bring it to full feature parity and comparable performance to the previous table chart that is based on [jQuery.Datatables](https://datatables.net/). We also had a failed attempt to replace it with another table library last year, which had to be reverted because of performance issues and edge cases.
   
   The same library (react-table) has been the foundation of the new list view and there's also [ongoing work](https://github.com/apache/incubator-superset/pulls?q=is%3Apr+react-table+is%3Aopen) to replace almost all other tables within Superset with the same library. `react-table` is here to stay, at least in the near future. So I would strongly advice against bringing in yet another table library.
   
   As to the feature request to this PR: actually, current table chart already supports multi-sort. It's just users have to do "Shift + Click". The library has an API to [override](https://react-table-omega.vercel.app/docs/api/useSortBy) this behavior (`isMultiSortEvent`). We can either add a control option to remove the requirement of shift + click, or add a tooltip to educate users about this behavior.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org