You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by outofmem0ry <gi...@git.apache.org> on 2017/11/21 01:58:36 UTC
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
GitHub user outofmem0ry opened a pull request:
https://github.com/apache/incubator-hawq/pull/1313
HAWQ-1553 Add option to hawq extract to specify log directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1313
----
commit 72a82e0a7693e17109486369ce10cc58d3d0b369
Author: Shubham Sharma <sh...@gmail.com>
Date: 2017-11-21T01:54:07Z
HAWQ-1553 Add option to hawq extract to specify log directory
----
---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1313#discussion_r152163943
--- Diff: tools/bin/hawqextract ---
@@ -558,13 +558,15 @@ def create_opt_parser(version):
parser.add_option('-o', '--output', help="the output metadata file, defaults to stdout", metavar='FILE')
parser.add_option('-W', action='store_true', dest='use_getpass', help="force password authentication")
parser.add_option('-v', '--verbose', action='store_true')
+ parser.add_option('-l', '--logdir', dest='logDir', help="Sets the directory for log files")
return parser
def main(args=None):
parser = create_opt_parser('%prog version $Revision: #1 $')
options, args = parser.parse_args(args)
+ setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(), logdir=options.logDir)
--- End diff --
If user doesn't give a logdir, the default value of `options.logDir` is?
Anyway, just make sure there is no problem.
Thanks!
---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1313#discussion_r152174954
--- Diff: tools/bin/hawqextract ---
@@ -558,13 +558,15 @@ def create_opt_parser(version):
parser.add_option('-o', '--output', help="the output metadata file, defaults to stdout", metavar='FILE')
parser.add_option('-W', action='store_true', dest='use_getpass', help="force password authentication")
parser.add_option('-v', '--verbose', action='store_true')
+ parser.add_option('-l', '--logdir', dest='logDir', help="Sets the directory for log files")
return parser
def main(args=None):
parser = create_opt_parser('%prog version $Revision: #1 $')
options, args = parser.parse_args(args)
+ setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(), logdir=options.logDir)
--- End diff --
@interma - setup_tool_logging defaults the value of logdir to None and handles it inside the function as seen from [here](https://github.com/apache/incubator-hawq/blob/e082d3adbb89a9e5ccb341da324ea9514cff5a35/tools/bin/gppylib/gplog.py#L130). I tested it locally and it works fine.
---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1313
---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1313
+1
---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1313#discussion_r152188060
--- Diff: tools/bin/hawqextract ---
@@ -558,13 +558,15 @@ def create_opt_parser(version):
parser.add_option('-o', '--output', help="the output metadata file, defaults to stdout", metavar='FILE')
parser.add_option('-W', action='store_true', dest='use_getpass', help="force password authentication")
parser.add_option('-v', '--verbose', action='store_true')
+ parser.add_option('-l', '--logdir', dest='logDir', help="Sets the directory for log files")
return parser
def main(args=None):
parser = create_opt_parser('%prog version $Revision: #1 $')
options, args = parser.parse_args(args)
+ setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(), logdir=options.logDir)
--- End diff --
Thanks!
LGTM.
---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1313
@radarwave Submitted PR for documentation https://github.com/apache/incubator-hawq-docs/pull/134
---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1313
Already merged, please close this PR. Thanks.
---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Posted by outofmem0ry <gi...@git.apache.org>.
Github user outofmem0ry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1313
@radarwave Can you please review this, will be submitting a different PR to docs repo to update documentation.
---