You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/03/01 02:17:07 UTC
[GitHub] [spark] amaliujia commented on a diff in pull request #40228: [SPARK-41874][CONNECT] Support SameSemantics in Spark Connect
amaliujia commented on code in PR #40228:
URL: https://github.com/apache/spark/pull/40228#discussion_r1121035854
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2724,7 +2724,7 @@ class Dataset[T] private[sql] (
}
def sameSemantics(other: Dataset[T]): Boolean = {
Review Comment:
In this PR I have added the python version. Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org