You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "charlespnh (via GitHub)" <gi...@apache.org> on 2025/08/29 15:26:33 UTC

[PR] [YAML] Fraud Detection Workflow Example [beam]

charlespnh opened a new pull request, #36012:
URL: https://github.com/apache/beam/pull/36012

   Part of the larger effort https://github.com/apache/beam/issues/35068 and https://github.com/apache/beam/issues/35072 to add more YAML example pipelines.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection Workflow Example [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36012:
URL: https://github.com/apache/beam/pull/36012#issuecomment-3237683272

   Assigning reviewers:
   
   R: @damccorm for label python.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection Workflow Example [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #36012:
URL: https://github.com/apache/beam/pull/36012#issuecomment-3237740872

   R: @chamikaramj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "charlespnh (via GitHub)" <gi...@apache.org>.
charlespnh commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2314612774


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   > Is it possible to add the YAML pipeline as a separate file as well with instructions for running similar to other examples ?
   
   I've given a lot of thought about this: The workflow is pretty complex with model training and several pipelines and custom transforms. I thought it makes more sense to place all these parts in a notebook so people can follow the example easily.
   Otherwise if the pipelines and model training are in separate files then a bash script is needed to tie them together into a workflow, and it wouldn't have a nice flow of explanation that a notebook can have.
   
   > That will be more convenient for someone whose looking to try/modify this example with different runners etc.
   
   User can still modify the example and try out with different runners inside this notebook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "charlespnh (via GitHub)" <gi...@apache.org>.
charlespnh commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2314612774


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   I've given a lot of thought about this: The workflow is pretty complex with model training and several pipelines and custom transforms. I thought it makes more sense to place all these parts in a notebook so people can follow the example easily.
   Otherwise if the pipelines and model training are in separate files then a bash script is needed to tie them together into a workflow, and it wouldn't have a nice flow of explanation that a notebook can have.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "charlespnh (via GitHub)" <gi...@apache.org>.
charlespnh commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2314612774


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   > Is it possible to add the YAML pipeline as a separate file as well with instructions for running similar to other examples ?
   
   I've given a lot of thought about this: The workflow is pretty complex with model training and several pipelines and custom transforms. I thought it makes more sense to place all these parts in a notebook so people can follow the example easily.
   Otherwise if the pipelines and model training are in separate files then a bash script is needed to tie them together into a workflow, and it wouldn't have a nice flow of explanation that a notebook can have.
   
   > That will be more convenient for someone whose looking to try/modify this example with different runners etc.
   
   User can still modify the example and try out with different runners even if it's in a notebook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "charlespnh (via GitHub)" <gi...@apache.org>.
charlespnh commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2314614894


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   CC @damccorm, @liferoad and @derrickaw to see if there's a better way to present this workflow example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj merged PR #36012:
URL: https://github.com/apache/beam/pull/36012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection MLOps Workflow Example [beam]

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2322720486


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   Sounds good. Let's get this in as is then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection Workflow Example [beam]

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2311711478


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 2.0 (the \"License\")\n",

Review Comment:
   Is it possible to add the YAML pipeline as a separate file as well with instructions for running similar to other examples ? That will be more convenient for someone whose looking to try/modify this example with different runners etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [YAML] Fraud Detection Workflow Example [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36012:
URL: https://github.com/apache/beam/pull/36012#issuecomment-3237743655

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org