[GitHub] [flink] hequn8128 commented on a change in pull request #9248: [FLINK-13446][table-runtime-blink] Fix assign logic for row count sliding window

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #9248: [FLINK-13446][table-runtime-blink] Fix assign logic for row count sliding window
URL: https://github.com/apache/flink/pull/9248#discussion_r308095686
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/window/WindowOperatorTest.java
 ##########
 @@ -1045,7 +1045,7 @@ public void testSlidingCountWindow() throws Exception {
 
 		testHarness.processWatermark(new Watermark(12000));
 		testHarness.setProcessingTime(12000L);
-		expectedOutput.add(record("key2", 15L, 5L, 0L));
+		expectedOutput.add(record("key2", 6L, 3L, 0L));
 
 Review comment:
   I think we have not missed outputs here. 
   For the slide window(size=5, slide=3), the first window is [-2,2], the second is [1, 5], so here, we only have one output for key2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services