You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by om...@apache.org on 2011/03/04 05:37:22 UTC

svn commit: r1077621 - /hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java

Author: omalley
Date: Fri Mar  4 04:37:21 2011
New Revision: 1077621

URL: http://svn.apache.org/viewvc?rev=1077621&view=rev
Log:
commit c9ec6f03fe508a44820662b409505197d3254223
Author: Luke Lu <ll...@yahoo-inc.com>
Date:   Thu Jul 29 18:42:35 2010 -0700

     Remove confusing stacktrace
    
    in metrics system startup code in dev testing mode.

Modified:
    hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java

Modified: hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java?rev=1077621&r1=1077620&r2=1077621&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java (original)
+++ hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java Fri Mar  4 04:37:21 2011
@@ -134,7 +134,8 @@ public class MetricsSystemImpl implement
     catch (MetricsConfigException e) {
       // Usually because hadoop-metrics2.properties is missing
       // We can always start the metrics system later via JMX.
-      LOG.warn("Metrics system not started!", e);
+      LOG.warn("Metrics system not started: "+ e.getMessage());
+      LOG.debug("Stacktrace: ", e);
     }
     initSystemMBean();
   }
@@ -496,6 +497,7 @@ public class MetricsSystemImpl implement
   }
 
   private void initSystemMBean() {
+    Contracts.checkNotNull(prefix, "prefix should not be null here!");
     mbeanName = MBeans.register(prefix, MS_CONTROL_NAME, this);
   }