You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/11 07:58:27 UTC

[GitHub] [avro] martin-g opened a new pull request, #1820: AVRO-3601: C++ API header contains breaking include

martin-g opened a new pull request, #1820:
URL: https://github.com/apache/avro/pull/1820

   Move impl/json/JsonDom.hh to api/json/
   
   https://github.com/apache/avro/blob/ce2439d7a7669a5c7f2fa555c661770fbe67493a/lang/c%2B%2B/CMakeLists.txt#L97
   includes the 'api/' folder, CMAKE_CURRENT_BINARY_DIR and Boost's
   include dirs
   
   ### Jira
   
   - [X] https://issues.apache.org/jira/browse/AVRO-3601
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1820: AVRO-3601: C++ API header contains breaking include

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1820:
URL: https://github.com/apache/avro/pull/1820#issuecomment-1211667605

   Ping @nileyadav @mruffing @chenrui333 
   Disclaimer: I am **not** C++ developer!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1820: AVRO-3601: C++ API header contains breaking include

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1820:
URL: https://github.com/apache/avro/pull/1820#issuecomment-1211868990

   I will work on this solution and I will create a new PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] thiru-mg commented on pull request #1820: AVRO-3601: C++ API header contains breaking include

Posted by GitBox <gi...@apache.org>.
thiru-mg commented on PR #1820:
URL: https://github.com/apache/avro/pull/1820#issuecomment-1211711217

   I think moving `jsonDom.hh` to API exposes a large portion of new material for public use. That puts a big constraint on us. Any new change to `jsonDom.hh` needs to be backward compatible. That is the actual reason I originally kept the entire JSON thing private. I am the author of much of the Avro C++ work. I strongly recommend some other approach to support custom fields. The JSON portion of the library, being private, not much thought went into designing and implementing it. We carefully kept the JSON from the data path, it is used only for parsing schemata and generating them. We do however use it for generating and reading Avro data for debugging purposes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g closed pull request #1820: AVRO-3601: C++ API header contains breaking include

Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1820: AVRO-3601: C++ API header contains breaking include
URL: https://github.com/apache/avro/pull/1820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1820: AVRO-3601: C++ API header contains breaking include

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1820:
URL: https://github.com/apache/avro/pull/1820#issuecomment-1211730494

   Thanks for the comment, @thiru-mg !
   
   What about replacing the internal JSON impl with a dependency (whatever is the most common used JSON library in C++ world) ?
   This is what many of the other Avro SDKs do. I don't know whether it is applicable/appropriate for the C++ SDK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org