You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/18 14:54:33 UTC

[GitHub] [flink] snuyanzin commented on a diff in pull request #20168: [FLINK-28324][flink-sql-client][JUnit5 Migration] Module: flink-sql-client

snuyanzin commented on code in PR #20168:
URL: https://github.com/apache/flink/pull/20168#discussion_r998345986


##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java:
##########
@@ -76,8 +82,8 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 /** Test that runs every {@code xx.q} file in "resources/sql/" path as a test. */
-@RunWith(Parameterized.class)
-public class CliClientITCase extends AbstractTestBase {
+@ExtendWith(TestLoggerExtension.class)
+public class CliClientITCase {

Review Comment:
   ```suggestion
   class CliClientITCase {
   ```
   It could be package private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org