You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/20 17:04:40 UTC

[jira] [Commented] (STORM-1227) port backtype.storm.config to java

    [ https://issues.apache.org/jira/browse/STORM-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108792#comment-15108792 ] 

ASF GitHub Bot commented on STORM-1227:
---------------------------------------

GitHub user zhuoliu opened a pull request:

    https://github.com/apache/storm/pull/1030

    [STORM-1227] port org.apache.storm.config to java

    1. Port "org.apache.storm.config" to java at "org.apache.storm.config.ConfigUtils".
    2. Update all the callings to the config functions.
    3. Mock the java static functions for test purposes.
    4. Address issues in unit and manual tests.
    5. Comment out most functions in config.clj except a few: cluster-mode (used in multimethod),  ALL-CONFIGS, clojure-config-name.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuoliu/storm 1227

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1030
    
----
commit 6ce984128fd92e42ae7018d6b27be753e7dfa30d
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-13T19:55:47Z

    [STORM-1227] Init commit for config.clj function translation to java

commit 0b90a63d5ac7075524e9fabc7a49bda47b41b946
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-13T22:45:39Z

    To continue update callers to read-storm-config

commit cb4cdf6910b9bc8bc9077d5ad0750707d14e5cb2
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-14T19:44:12Z

    mock read-storm-config in drpc_test

commit f350f1ae9aaa44ea8f931c5e48eef5051d79770d
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-14T20:34:43Z

    Update all the callings to read-storm-config and add the import for ConfigUtils

commit 3d2796d2fbd7ae182d7414db985cf7de167fcd82
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-14T21:25:47Z

    Update callings to supervisor-isupervisor-dir

commit 635488db5e0670f1e4348fab5e3fd7d3970c5e63
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-15T18:50:00Z

    Updated to callings for supervisor-stormjar-path

commit 99189a6016d24aff485b9206323ad68988d32be1
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-15T19:10:20Z

    Updated to supervisor-storm-resources-path

commit 310128d9469f2151851d4e44710593b6ebcbac59
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-15T19:33:52Z

    updated to nimbus-topo-history-state

commit ba70bf1cfe72aeabec104d8ea664f087b719a08c
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-15T20:28:04Z

    Updated to read-supervisor-storm-conf

commit 0dbdcf39bf411a4ee5abac5e740c07e8813ea025
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-17T22:37:35Z

    Updates workerRoot, worker user, path, state, set. To do a few left.

commit 7c3fec6502ab23855a0b31dbb93debe7e22e73ff
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-19T17:23:26Z

    Updated callings before get-topo-logs-users

commit 13ab1515c503ad3eefe10871b5972d4bce60fde6
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-19T17:38:05Z

    Updated all callings

commit fd37de911ad73cf1a6f0d5500d0c1532a7ece209
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-19T22:54:10Z

    Updated for all the rest that we can do

commit b4847b76f0222344a51987fce1c8180616a4c279
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-19T23:33:51Z

    Manual test

commit b7374d2bb4cf49111936ec1cbd2a4f4f22661100
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-20T15:54:30Z

    Cleanup the comments

----


> port backtype.storm.config to java
> ----------------------------------
>
>                 Key: STORM-1227
>                 URL: https://issues.apache.org/jira/browse/STORM-1227
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>              Labels: java-migration, jstorm-merger
>
> port backtype.storm.config to java.  There are some parts of this that for convince sake may need to stay in clojure, or have clojure equivalents.
> The code that turns Config.* into clojure constants needs to stay, and reading the config may need to stay in clojure until we can cleanup all of the places it is used to not need the migration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)