You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/12/31 19:35:29 UTC
[jira] Created: (THRIFT-670) Unions don't skip unrecognizable
fields correctly
Unions don't skip unrecognizable fields correctly
-------------------------------------------------
Key: THRIFT-670
URL: https://issues.apache.org/jira/browse/THRIFT-670
Project: Thrift
Issue Type: Bug
Components: Compiler (Java), Library (Java)
Affects Versions: 0.2
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Fix For: 0.3
I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-670) Unions don't skip unrecognizable
fields correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795641#action_12795641 ]
Bryan Duxbury commented on THRIFT-670:
--------------------------------------
The IllegalStateException is only there to please the compiler. It should be unreachable.
> Unions don't skip unrecognizable fields correctly
> -------------------------------------------------
>
> Key: THRIFT-670
> URL: https://issues.apache.org/jira/browse/THRIFT-670
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-670.patch
>
>
> I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-670) Unions don't skip unrecognizable
fields correctly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795639#action_12795639 ]
David Reiss commented on THRIFT-670:
------------------------------------
Can that IllegalStateException happen for anything other than a (previously unknown) bug in Thrift? If not, LG.
> Unions don't skip unrecognizable fields correctly
> -------------------------------------------------
>
> Key: THRIFT-670
> URL: https://issues.apache.org/jira/browse/THRIFT-670
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-670.patch
>
>
> I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-670) Unions don't skip unrecognizable fields
correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-670.
--------------------------------
Resolution: Fixed
Committed.
> Unions don't skip unrecognizable fields correctly
> -------------------------------------------------
>
> Key: THRIFT-670
> URL: https://issues.apache.org/jira/browse/THRIFT-670
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-670.patch
>
>
> I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-670) Unions don't skip unrecognizable
fields correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-670:
---------------------------------
Patch Info: [Patch Available]
> Unions don't skip unrecognizable fields correctly
> -------------------------------------------------
>
> Key: THRIFT-670
> URL: https://issues.apache.org/jira/browse/THRIFT-670
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-670.patch
>
>
> I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-670) Unions don't skip unrecognizable
fields correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-670:
---------------------------------
Attachment: thrift-670.patch
This patch adds a test for this problem and fixes it.
> Unions don't skip unrecognizable fields correctly
> -------------------------------------------------
>
> Key: THRIFT-670
> URL: https://issues.apache.org/jira/browse/THRIFT-670
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-670.patch
>
>
> I'm getting a NullPointerException when trying to read a Union struct off the wire which has a value that's not recognized by the current version of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.