You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 16:37:52 UTC

[GitHub] [airflow] potiuk commented on pull request #18079: Chart: fix webserver secret key update

potiuk commented on pull request #18079:
URL: https://github.com/apache/airflow/pull/18079#issuecomment-915393804


   > Maybe the best thing is for users to explicitly set webserverSecretKey, then the annotations work perfectly!
   
   @jedcunningham - I do agree with the statement. So maybe we should be more explicit about it?
   
   Idea:
   
   While I  think the random generation is rather useful for quick start, however, maybe it should be accompanied by a big fat warning (possibly including a warning generated in the UI) - directing user to generate both Fernet Key and Webserver key manually. We already'we done a few of those - for example Sequential executor + Sqlite recently.
   
   I think showing a UI warning is the only one that is going to work, but it will be very effectitve and make people generate those.
   
   I think it could be a feature of airflow - simply a variable set ``AIRFLOW__CORE__FERNET_KEY_GENERATED_AUTOMATICALLY`` or something like that that could show the warning, or maybe Airflow Variable set in the DB in such case... 
   
   Just wild thought :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org