You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/12 23:05:18 UTC

[GitHub] merlimat opened a new pull request #2790: [cpp] Removed required version 5.0 for CLang format

merlimat opened a new pull request #2790: [cpp] Removed required version 5.0 for CLang format
URL: https://github.com/apache/pulsar/pull/2790
 
 
   ### Motivation
   
   On MacOS, CMake fails to find `clang-format` even if the correct version is available, therefore `make format` on C++ builds fails. This makes it harder to fix the formatting on macos. 
   
   ### Modifications
   
   Do not require particular version of `clang-format` (though on CI we keep using 5.0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services