You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2009/06/30 03:04:47 UTC
[jira] Created: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
----------------------------------------------------------------------------------------
Key: HBASE-1591
URL: https://issues.apache.org/jira/browse/HBASE-1591
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: Jonathan Gray
Assignee: Jonathan Gray
Fix For: 0.20.0
Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
{noformat}
Error Message
expected:<0> but was:<1>
Stacktrace
junit.framework.AssertionFailedError: expected:<0> but was:<1>
at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
{noformat}
Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1591:
---------------------------------
Attachment: HBASE-1591-v2.patch
Fixes a problem with alignment of String calculation and cleans the patch a little more.
Tested on 32bit windows and 64bit linux. Would like to get verification from a few others that tests pass before committing.
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch, HBASE-1591-v2.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1591:
---------------------------------
Attachment: HBASE-1591-v1.patch
Cleans up TestLruBlockCache a great deal. I was doing a lot of hard-coding of block sizes, cache sizes, etc... Was an imperfect science and not very portable.
I made LruBlockCache only have heapSize, not a separate cacheSize. The unit tests are also fully testing the heap size tracking.
Any further work for sizing of this will be in HBASE-1590 though I'm not sure how necessary that is anymore.
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725426#action_12725426 ]
Jonathan Gray commented on HBASE-1591:
--------------------------------------
This is turning into a bit more of a fix on the LRU's sizing. Patch soon.
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1591:
---------------------------------
Status: In Progress (was: Patch Available)
One of the TestHeapSize tests is failing on a development box.
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1591:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Tested two tests passed locally. Committed. Let hudson tell us if its fixed hudson or not.
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch, HBASE-1591-v2.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1591:
---------------------------------
Status: Patch Available (was: Open)
Please review and verify TestHeapSize and TestLruBlockCache pass. Will be helpful to know your platform (OS/JVM and 32bit or 64bit)
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1591) HBASE-1554 broke
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1591:
---------------------------------
Status: Patch Available (was: In Progress)
> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-1591
> URL: https://issues.apache.org/jira/browse/HBASE-1591
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1591-v1.patch, HBASE-1591-v2.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.