You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/19 11:34:57 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5258: add touchscreen uinput driver

xiaoxiang781216 commented on a change in pull request #5258:
URL: https://github.com/apache/incubator-nuttx/pull/5258#discussion_r787657699



##########
File path: drivers/input/touchscreen_upper.c
##########
@@ -90,7 +92,7 @@ static const struct file_operations g_touch_fops =
   touch_open,     /* open */
   touch_close,    /* close */
   touch_read,     /* read */
-  NULL,           /* write */
+  touch_write,    /* write */

Review comment:
       @acassis the callback just add a dummy function with several bytes, does it make sense to couple the general code with uinput?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org