You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Craig L Russell (JIRA)" <ji...@apache.org> on 2010/02/23 21:43:27 UTC
[jira] Created: (OPENJPA-1530) Support specification of storage
engine type for MySQL
Support specification of storage engine type for MySQL
------------------------------------------------------
Key: OPENJPA-1530
URL: https://issues.apache.org/jira/browse/OPENJPA-1530
Project: OpenJPA
Issue Type: Improvement
Components: jdbc
Reporter: Craig L Russell
Assignee: Craig L Russell
Priority: Minor
Fix For: 1.3.0
The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
Also, according to the MySQL documentation, TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
Also, a property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell updated OPENJPA-1530:
-------------------------------------
Fix Version/s: 1.3.0
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell closed OPENJPA-1530.
------------------------------------
Thanks for the assistance resolving this.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell updated OPENJPA-1530:
-------------------------------------
Attachment: openjpa-1530.patch
Please review this patch. It makes schema creation possible for MySQL engines other than MyISAM or innodb.
It adds a property jdbc.mysql.Engine to the JDBC Configuration. This allows the MySQL engine type to be specified on the command line via -Dopenjpa.jdbc.mysql.Engine=ndbcluster or in persistence.xml <property name="openjpa.jdbc.mysql.Engine" value="ndbcluster".
I didn't see other XXXDictionary implementations with special properties so I guessed this is the way to get the JDBC Configuration to hold the value and for MySQLDictionary to get the value. If there is a different pattern I should use, please let me know.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841552#action_12841552 ]
Craig L Russell commented on OPENJPA-1530:
------------------------------------------
Do you think I need a test case for this? Seems straightforward enough and I'll be testing it pretty thoroughly myself.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1530) MySQL storage engine support
Posted by "Jeremy Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841504#action_12841504 ]
Jeremy Bauer commented on OPENJPA-1530:
---------------------------------------
I agree with Milosz. The property does not go beyond the scope of the dictionary so it should be localized to the MySQL dictionary. For example:
<property name="openjpa.jdbc.DBDictionary" value="mysql(Engine=ndbcluster)"/>.
You just need to provide a getter and setter (or public field) for "Engine" in the MySQL dictionary and the config framework will take care of setting the value. Also, if you add a new dictionary value please update the OpenJPA docs specific to the MySQL dictionary. Oh, and the print statement needs to be removed. :-)
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1530) MySQL storage engine support
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated OPENJPA-1530:
----------------------------------
Fix Version/s: (was: 2.0.0)
2.0.0-beta3
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0-beta3
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1530) MySQL storage engine support
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841672#action_12841672 ]
Michael Dick commented on OPENJPA-1530:
---------------------------------------
I agree with Milosz & Jeremy - the engine variable should be moved to MySQLDictionary.
If we do add a testcase I'd rather have it only run on MySQL instead of excluding it entirely (we'll forget about it if it's excluded). We'd just need to set the engine property to ndbcluster and verify that we can create a table.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell updated OPENJPA-1530:
-------------------------------------
Fix Version/s: (was: 1.3.0)
2.0.0
This update should be widely available, especially for 2.0
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1530) MySQL storage engine support
Posted by "Jeremy Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841561#action_12841561 ]
Jeremy Bauer commented on OPENJPA-1530:
---------------------------------------
IMO, no. Since it requires a special environment and will be disabled in the normal test runs anyway. But, if you'd like to add a test and put it in the excludes list that would be a bonus. It would be handy to have if it was ever needed for regression or specialized testing of that environment.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1530) MySQL storage engine support
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840248#action_12840248 ]
Milosz Tylenda commented on OPENJPA-1530:
-----------------------------------------
Hi Craig. The Dictionaries support their special properties just by having public variables. MySQLDictionary currently supports the "tableType" property this way. You can override it by using
<property name="openjpa.jdbc.DBDictionary" value="mysql(TableType=ndbcluster)"/>
or
<property name="openjpa.jdbc.DBDictionary" value="TableType=ndbcluster"/>
I think that the only change you want here is:
+ @Override
public String[] getCreateTableSQL(Table table) {
String[] sql = super.getCreateTableSQL(table);
- if (!StringUtils.isEmpty(tableType))
- sql[0] = sql[0] + " TYPE = " + tableType;
+ if (!StringUtils.isEmpty(engine))
+ sql[0] = sql[0] + " ENGINE = " + engine;
return sql;
}
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell resolved OPENJPA-1530.
--------------------------------------
Resolution: Fixed
Committed changes to 1.3.x and trunk:
public String[] getCreateTableSQL(Table table) {
String[] sql = super.getCreateTableSQL(table);
if (!StringUtils.isEmpty(tableType))
- sql[0] = sql[0] + " TYPE = " + tableType;
+ sql[0] = sql[0] + " ENGINE = " + tableType;
return sql;
Since tableType is already documented, there's no need to change it.
svn commit -m "OPENJPA-1530 change TYPE to ENGINE in DDL for MySQL"
Sending openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/MySQLDictionary.java
Transmitting file data .
Committed revision 920979.
clr% svn commit -m "OPENJPA-1530 change TYPE to ENGINE in DDL for MySQL"
Sending openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/MySQLDictionary.java
Transmitting file data .
Committed revision 920977.
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1530) MySQL storage engine support
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig L Russell updated OPENJPA-1530:
-------------------------------------
Description:
The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
"Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
was:
The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
Also, according to the MySQL documentation, TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
Also, a property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines.
Summary: MySQL storage engine support (was: Support specification of storage engine type for MySQL)
> MySQL storage engine support
> ----------------------------
>
> Key: OPENJPA-1530
> URL: https://issues.apache.org/jira/browse/OPENJPA-1530
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc
> Reporter: Craig L Russell
> Assignee: Craig L Russell
> Priority: Minor
> Fix For: 1.3.0
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE.
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.