You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/09/29 01:51:03 UTC
[GitHub] [pinot] Jackie-Jiang opened a new issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Jackie-Jiang opened a new issue #7494:
URL: https://github.com/apache/pinot/issues/7494
Currently when executing a query, we extract the query options out and pass them in as arguments into the plan nodes and operators. This approach will add more and more arguments into the method, which is hard to maintain.
Instead, we can store these arguments within the query context so that adding new options doesn't require changing the method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] yupeng9 commented on issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
yupeng9 commented on issue #7494:
URL: https://github.com/apache/pinot/issues/7494#issuecomment-942815759
This is significant as it allows the fine-grained resource control in the multi-tenant cluster, and also protects the cluster from poison queries. Look forward to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7494:
URL: https://github.com/apache/pinot/issues/7494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kishoreg commented on issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
kishoreg commented on issue #7494:
URL: https://github.com/apache/pinot/issues/7494#issuecomment-929805932
Can we also add request id to the context in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kishoreg commented on issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
kishoreg commented on issue #7494:
URL: https://github.com/apache/pinot/issues/7494#issuecomment-929805932
Can we also add request id to the context in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7494:
URL: https://github.com/apache/pinot/issues/7494#issuecomment-930368175
+1000.
Also this object can carry over the query runtime info, e.g. request id for tracing, query start time for handling timeout etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7494: [Cleanup] Set instance-level and table-level query options into query context
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7494:
URL: https://github.com/apache/pinot/issues/7494#issuecomment-930368175
+1000.
Also this object can carry over the query runtime info, e.g. request id for tracing, query start time for handling timeout etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org