You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/07 14:29:47 UTC
[GitHub] [pulsar] limingnihao opened a new pull request #9521: [Issue9507][testclient] add --batch-index-ack for the pulsar-perf
limingnihao opened a new pull request #9521:
URL: https://github.com/apache/pulsar/pull/9521
add --batch-index-ack for the pulsar-perf consume command and keep it as false by default.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #9507
### Motivation
PIP-45 https://github.com/apache/pulsar/wiki/PIP-54:-Support-acknowledgment-at-batch-index-level introduced batch index level acknowledge but the pulsar-perf client does not support to enable it for the consumer. It's better to allow users to do the performance test for the batch index acknowledgment.
### Modifications
add --batch-index-ack for the pulsar-perf consume command and keep it as false by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9521: [Issue9507][testclient] add --batch-index-ack for the pulsar-perf
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9521:
URL: https://github.com/apache/pulsar/pull/9521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #9521: [Issue9507][testclient] add --batch-index-ack for the pulsar-perf
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #9521:
URL: https://github.com/apache/pulsar/pull/9521#discussion_r571727405
##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -168,6 +168,9 @@
@Parameter(names = {"-ioThreads", "--num-io-threads"}, description = "Set the number of threads to be " +
"used for handling connections to brokers, default is 1 thread")
public int ioThreads = 1;
+
+ @Parameter(names = {"--batch-index-ack" }, description = "Enable or disable the batch index acknowledgment")
Review comment:
```suggestion
@Parameter(names = { "--batch-index-ack" }, description = "Enable or disable the batch index acknowledgment")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org