[GitHub] [pinot] jackjlli commented on a change in pull request #8174: Adding scala profile for kafka 2.x build and remove root pom scala dependencies

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #8174:
URL: https://github.com/apache/pinot/pull/8174#discussion_r802991014



##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/pom.xml
##########
@@ -100,4 +98,28 @@
       <artifactId>jopt-simple</artifactId>
     </dependency>
   </dependencies>
+
+
+  <profiles>
+    <profile>
+      <id>scala-2.12</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       This basically means the default scala version got downgraded from 2.13 to 2.12 in the project. Could you elaborate a bit more on the reason of doing that to the description?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org