You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/17 07:57:49 UTC
[GitHub] [skywalking] VictorZeng opened a new pull request #7736: Add Alibaba Druid plugin
VictorZeng opened a new pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736
add alibaba druid plugin
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Related #7735.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] VictorZeng commented on a change in pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
VictorZeng commented on a change in pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#discussion_r711757104
##########
File path: CHANGES.md
##########
@@ -69,6 +69,7 @@ Release Notes.
* Improve the speed of writing TiDB by batching the SQL execution.
* Fix wrong service name when IP is node IP in `k8s-mesh`.
* Support dynamic configurations for openAPI endpoint name grouping rule.
+* Add component definition for `Alibaba Druid`.
Review comment:
OK, I get it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#issuecomment-922471306
> Update the CHANGES log.
Notice, you clicked this, but you don't update the changes.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#discussion_r711755890
##########
File path: CHANGES.md
##########
@@ -69,6 +69,7 @@ Release Notes.
* Improve the speed of writing TiDB by batching the SQL execution.
* Fix wrong service name when IP is node IP in `k8s-mesh`.
* Support dynamic configurations for openAPI endpoint name grouping rule.
+* Add component definition for `Alibaba Druid`.
Review comment:
FYI @VictorZeng This is the changelog for main repo. From SkyWalking backend perspective, we don't care about the plugin added at agent side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#discussion_r711736020
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -374,6 +374,9 @@ Sentinel:
GuavaCache:
id: 114
languages: Java
+druid:
Review comment:
```suggestion
AlibabaDruid:
```
According to https://github.com/apache/skywalking-java/pull/27/files#r711735928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#issuecomment-922471089
Wait for https://github.com/apache/skywalking-java/pull/27 ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7736: Add Alibaba Druid plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7736:
URL: https://github.com/apache/skywalking/pull/7736#issuecomment-921909457
Pending on https://github.com/apache/skywalking-java/pull/26 review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org