You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/13 01:34:14 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2484: feat(github): collect comments/reviews
warren830 opened a new pull request, #2484:
URL: https://github.com/apache/incubator-devlake/pull/2484
# Summary
1. collect normal comments, inline comments and reviews for github
2. store normal/inline comments in _tool_github_pull_request_comments
3. store reviews in _tool_github_pull_request_reviews
4. convert all comments/reviews to pull_request_comments
### Does this close any open issues?
closes #2452
### Screenshots
_tool_github_pull_request_comments
<img width="631" alt="image" src="https://user-images.githubusercontent.com/39366025/178629378-9816bdfa-317e-40f1-854a-85d44d3927f3.png">
_tool_github_pull_request_reviews
<img width="982" alt="image" src="https://user-images.githubusercontent.com/39366025/178629417-e55d55a4-aef8-45a5-8217-7825111d2b95.png">
pull_request_comments
<img width="956" alt="image" src="https://user-images.githubusercontent.com/39366025/178629441-9fc99ed3-b61b-48c2-afcd-71eec0aeb45b.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #2484: feat(github): collect comments/reviews
Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #2484:
URL: https://github.com/apache/incubator-devlake/pull/2484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #2484: feat(github): collect comments/reviews
Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #2484:
URL: https://github.com/apache/incubator-devlake/pull/2484#discussion_r919611412
##########
models/migrationscripts/init_schema.go:
##########
@@ -115,7 +115,7 @@ func (*initSchemas) Up(ctx context.Context, db *gorm.DB) error {
}
func (*initSchemas) Version() uint64 {
- return 20220707232344
+ return 20220711232344
Review Comment:
Isn't this going to cause this migration to be ran again and therefore drop all existing tables via Up()? Wouldn't that cause data loss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2484: feat(github): collect comments/reviews
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2484:
URL: https://github.com/apache/incubator-devlake/pull/2484#discussion_r919835075
##########
models/migrationscripts/init_schema.go:
##########
@@ -115,7 +115,7 @@ func (*initSchemas) Up(ctx context.Context, db *gorm.DB) error {
}
func (*initSchemas) Version() uint64 {
- return 20220707232344
+ return 20220711232344
Review Comment:
Yes, this will cause data loss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org