You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Bikas Saha (JIRA)" <ji...@apache.org> on 2014/03/01 21:02:19 UTC

[jira] [Commented] (TEZ-884) Add assertion of arguments at API level

    [ https://issues.apache.org/jira/browse/TEZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917176#comment-13917176 ] 

Bikas Saha commented on TEZ-884:
--------------------------------

What is this doing?
{code}+    groupInputSpecList =
+        Optional.fromNullable(groupInputSpecList).or(Collections.EMPTY_LIST);{code}

We probably dont need an empty list to be created.

> Add assertion of arguments at API level
> ---------------------------------------
>
>                 Key: TEZ-884
>                 URL: https://issues.apache.org/jira/browse/TEZ-884
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: TEZ-884.1.patch
>
>
> I'm taking TEZ-865, and struggling with NPE. It's very effective to avoid NPE by adding @Nullable annotation and assert arguments by Preconditions.checkNotNull at API level.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)