[jira] [Commented] (BIGTOP-1527) Allow to fetch package's source code from Git

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230314#comment-14230314 ] 

Konstantin Boudnik commented on BIGTOP-1527:
--------------------------------------------

Thanks [~ivanorlov], appreciate the push. BTW, you don't need to remove previous patches from the JIRA as they might be good to have for future revisiting of the patch history. 
Instead just keep adding them under the same name and JIRA will sort them out properly, so you always know which one is the latest.

A minor comment (not worthy redoing the patch though)
- you don't need {{dir == null}} as just above you had {{if (GIT_REPO && GIT_REF) }}

+1 I will commit it shortly.




> Allow to fetch package's source code from Git
> ---------------------------------------------
>
>                 Key: BIGTOP-1527
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1527
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.8.0
>            Reporter: Ivan Orlov
>            Assignee: Ivan Orlov
>         Attachments: 0001-BIGTOP-1527.-Allow-to-fetch-package-s-source-code-fr.patch
>
>
> For development purposes. It's useful to target Bigtop on Git-repository of your own package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)