[jira] [Commented] (HBASE-5418) use different memstoreTS for different operations in the same RowMutation.

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219654#comment-13219654 ] 

Phabricator commented on HBASE-5418:
------------------------------------

aaiyer has commented on the revision "HBASE-5418 [jira] use different memstoreTS for different operations in the same RowMutation.".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4245 I think we should completeMemstoreInsert for all the writeEntries, regardless of weather they suceed or not.

  If we do not call completeMemstoreInsert (for a incomplete operation), then none of the puts/deletes that start after that operation can ever complete.

  As long as we are "totally giving up" on retrying the operation, technically, it should be fine to call completeMemstoreInsert. All it does, as far as I can tell, is to remove the writeEntry from the list of "current writes".

  (Although, from code inspection, it seems unlikely why one will suceed and the other does not --- because applyFamilyMapToMemstore does not seem to throw exceptions).

REVISION DETAIL
  https://reviews.facebook.net/D1761

                
> use different memstoreTS for different operations in the same RowMutation.
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5418
>                 URL: https://issues.apache.org/jira/browse/HBASE-5418
>             Project: HBase
>          Issue Type: Sub-task
>          Components: client, coprocessors, regionserver
>            Reporter: Amitanand Aiyer
>            Assignee: Amitanand Aiyer
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5418.D1761.1.patch
>
>
> Assigning different memstoreTS will enable us to guarantee that the
> operations will appear to take effect, along the same order, in which
> they were added to create the RowMutation.
> Based on the diff after renaming to RowMutations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira