You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/24 19:54:19 UTC

[GitHub] [airflow] uranusjr commented on pull request #19808: Refactor dangling row check to use SQLA queries

uranusjr commented on pull request #19808:
URL: https://github.com/apache/airflow/pull/19808#issuecomment-978177249


   Honestly I feel this is a massive degrade on readability, but I guess that’s more or less how ORMs work in general to balance between code duplication and hairy string manipulation.
   
   > Codespell doesn't currently have a method of ignoring a _single_ line without ignoring the word everywhere (which we don't want to do) so I have to ignore the exact _line_.
   
   Including the leading whitespace? That’s… uh.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org