You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mike Klaas (JIRA)" <ji...@apache.org> on 2007/11/07 01:42:50 UTC
[jira] Created: (SOLR-407) Uncached filter query parameters
Uncached filter query parameters
--------------------------------
Key: SOLR-407
URL: https://issues.apache.org/jira/browse/SOLR-407
Project: Solr
Issue Type: New Feature
Components: search
Affects Versions: 1.3
Reporter: Mike Klaas
Assignee: Mike Klaas
Priority: Minor
Fix For: 1.3
Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-407) Uncached filter query parameters
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-407:
----------------------------
Attachment: fq.nocache.patch
To implement I exposed one method of QueryUtils (getAbs) so that negative filters can be added as prohibited clauses.
> Uncached filter query parameters
> --------------------------------
>
> Key: SOLR-407
> URL: https://issues.apache.org/jira/browse/SOLR-407
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-407) Uncached filter query parameters
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-407:
------------------------------
Fix Version/s: 1.5
on my wishlist, targeting this for 1.5
> Uncached filter query parameters
> --------------------------------
>
> Key: SOLR-407
> URL: https://issues.apache.org/jira/browse/SOLR-407
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.5
>
> Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-407) Uncached filter query parameters
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541129 ]
Mike Klaas commented on SOLR-407:
---------------------------------
Good catch! This can be fixed in standard request handler as follows:
if(null != ncFilters) {
BooleanQuery target;
if(query instanceof BooleanQuery) {
target = (BooleanQuery)query;
} else {
target = new BooleanQuery(true);
target.add(query, BooleanClause.Occur.MUST);
}
U.addFilters(ncFilters, target);
query = target;
}
DisMax I don't think is a problem since it is adding to the top-level boolean query (can the dismax parser produce pure negative queries anyway?)
I've fixed this with a test in my local copy. If we pursue this any further, I'll post a patch (also incorporating Yonik's localParams suggestion).
> Uncached filter query parameters
> --------------------------------
>
> Key: SOLR-407
> URL: https://issues.apache.org/jira/browse/SOLR-407
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-407) Uncached filter query parameters
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541078 ]
Hoss Man commented on SOLR-407:
-------------------------------
Mike: one thing that's not clear to me from a quick glance at your patch is wether or not this case works...
q= -foo & fq.nocache=bar
...i *think* that in your patch, a boolean query containing one negative foo clause gets added to a new "target" query as a mandatory clause along with the fq.nocache ... and the SolrIndexSearcher code for detecting a pure negative query and finding the inverse doesn't get tripped.
> Uncached filter query parameters
> --------------------------------
>
> Key: SOLR-407
> URL: https://issues.apache.org/jira/browse/SOLR-407
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-407) Uncached filter query parameters
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-407:
----------------------------
Fix Version/s: (was: 1.3)
> Uncached filter query parameters
> --------------------------------
>
> Key: SOLR-407
> URL: https://issues.apache.org/jira/browse/SOLR-407
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses to the query which are not cached. Further, these filters are embedded directly into the BooleanQuery, which should be more efficient when filters are not reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.