[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2191: Fix disabling parquet statistics (#2185)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2191:
URL: https://github.com/apache/arrow-rs/pull/2191#discussion_r930955415


##########
parquet/src/column/writer/mod.rs:
##########
@@ -456,7 +456,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
             for &level in levels {
                 if level == self.descr.max_def_level() {
                     values_to_write += 1;
-                } else if self.statistics_enabled == EnabledStatistics::Page {
+                } else {
+                    // We must always compute this as it is used to populate v2 pages

Review Comment:
   Previously this would cause an incorrect null count in the data page v2 header



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org