You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/24 16:22:03 UTC
[GitHub] [spark] abellina commented on a change in pull request #24541:
[SPARK-27646] [SQL] [WIP] Required refactoring for bytecode analysis
abellina commented on a change in pull request #24541: [SPARK-27646] [SQL] [WIP] Required refactoring for bytecode analysis
URL: https://github.com/apache/spark/pull/24541#discussion_r287424350
##########
File path: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala
##########
@@ -27,6 +26,7 @@ import org.apache.xbean.asm7.Opcodes._
import org.apache.spark.{SparkEnv, SparkException}
import org.apache.spark.internal.Logging
+import org.apache.spark.util.Utils.getSerializedLambda
Review comment:
since we are already in `org.apacke.spark.util`, could we just call `Utils.getSerializedLambda` from the `clean`? We seem to refer to other static functions in `Utils` using the classname.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org