[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #3187: [GOBBLIN-1348] Uses own logic for generating tags instead of the docker meta action

[GitBox <gi...@apache.org>]

Will-Lo commented on a change in pull request #3187:
URL: https://github.com/apache/incubator-gobblin/pull/3187#discussion_r550830367



##########
File path: .github/workflows/docker_build_publish.yaml
##########
@@ -21,44 +21,60 @@ on:
     # Publish only on `master`
     branches:
       - master
-
+  pull_request:

Review comment:
       It'll trigger the build whenever there is a push on master, when there is a new release or when there is a new pull request against master (and anytime that branch is updated after the PR is created)
   
   In the build and push action I prevent pushing to the repository if the event is a pull request, so it should only be used to check if the docker file modifications/github actions modifications are valid without creating a new image on dockerhub.
   
   Also it should only be triggering the CI if the PR includes a file that modifies the docker file or the github action




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org