svn commit: r613243 - /maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java

[jd...@apache.org]

Author: jdcasey
Date: Fri Jan 18 11:49:45 2008
New Revision: 613243

URL: http://svn.apache.org/viewvc?rev=613243&view=rev
Log:
adding comments about TransferFailedException...this was a gotcha moment when I was working on error-reporting in maven proper.

Modified:
    maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java

Modified: maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
URL: http://svn.apache.org/viewvc/maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java?rev=613243&r1=613242&r2=613243&view=diff
==============================================================================
--- maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java (original)
+++ maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java Fri Jan 18 11:49:45 2008
@@ -40,9 +40,9 @@
 import org.apache.maven.wagon.repository.RepositoryPermissions;
 import org.codehaus.plexus.PlexusConstants;
 import org.codehaus.plexus.PlexusContainer;
+import org.codehaus.plexus.component.configurator.BasicComponentConfigurator;
 import org.codehaus.plexus.component.configurator.ComponentConfigurationException;
 import org.codehaus.plexus.component.configurator.ComponentConfigurator;
-import org.codehaus.plexus.component.configurator.BasicComponentConfigurator;
 import org.codehaus.plexus.component.repository.exception.ComponentLifecycleException;
 import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
 import org.codehaus.plexus.configuration.PlexusConfiguration;
@@ -98,7 +98,7 @@
     private boolean interactive = true;
 
     private RepositoryPermissions defaultRepositoryPermissions;
-    
+
     // Components
 
     /** @plexus.requirement */
@@ -312,6 +312,9 @@
         }
     }
 
+
+    // NOTE: It is not possible that this method throws TransferFailedException under current conditions.
+    // FIXME: Change the throws clause to reflect the fact that we're never throwing TransferFailedException
     public void getArtifact( Artifact artifact,
                              List remoteRepositories )
         throws TransferFailedException, ResourceDoesNotExistException
@@ -821,7 +824,7 @@
         authenticationInfoMap.put( repositoryId, authInfo );
     }
 
-    // This is the new way of handling authentication that will allow us to help users setup 
+    // This is the new way of handling authentication that will allow us to help users setup
     // authentication requirements.
     public void addAuthenticationCredentials( String repositoryId
         ,
@@ -916,6 +919,7 @@
     }
 
     /** @deprecated Wagons are discovered in plugin and extension realms now. */
+    @Deprecated
     public void registerWagons( Collection wagons,
                                 PlexusContainer extensionContainer )
     {
@@ -992,7 +996,7 @@
 
     public void registerCredentialsDataSource( CredentialsDataSource cds )
     {
-        this.credentialsDataSource = cds;
+        credentialsDataSource = cds;
     }